| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jim Nasby <jim(at)nasby(dot)net>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch: make_timestamp function |
| Date: | 2013-12-17 17:07:38 |
| Message-ID: | CAFj8pRBfRSrMjctgM33oqZW9LOSc9DWM_Z8FHZ_4=R58BnY1=g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
2013/12/17 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
>
>
>
> 2013/12/17 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
>
>> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> > Yeah, I think a constructor should allow a text timezone.
>>
>> Yes. I think a numeric timezone parameter is about 99% useless,
>> and if you do happen to need that behavior you can just cast the
>> numeric to text no?
>
>
> yes, it is possible. Although fully numeric API is much more consistent.
>
>
I was wrong - there are timezones with minutes like Iran = '1:30';
so int in hours is bad type - so only text is probably best
Pavel
> Pavel
>
>
>>
>> regards, tom lane
>>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-12-17 17:08:11 | Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication |
| Previous Message | Robert Haas | 2013-12-17 17:03:27 | Re: row security roadmap proposal |