Re: patch: make_timestamp function

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jim Nasby <jim(at)nasby(dot)net>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: make_timestamp function
Date: 2013-12-17 17:33:01
Message-ID: 20131217173301.GE19059@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 17, 2013 at 06:07:38PM +0100, Pavel Stehule wrote:
> Hello
>
>
> 2013/12/17 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
>
>
>
>
> 2013/12/17 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
>
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Yeah, I think a constructor should allow a text timezone.
>
> Yes.  I think a numeric timezone parameter is about 99% useless,
> and if you do happen to need that behavior you can just cast the
> numeric to text no?
>
>
> yes, it is possible. Although fully numeric API is much more consistent.
>
>
>
> I was wrong - there are timezones with minutes like Iran = '1:30';
>
> so int in hours is bad type - so only text is probably best

I think India is the big non-integer timezone offset country:

http://www.timeanddate.com/worldclock/city.html?n=176
UTC/GMT +5:30 hours

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2013-12-17 17:35:35 Re: pg_rewarm status
Previous Message Tom Lane 2013-12-17 17:28:33 Re: planner missing a trick for foreign tables w/OR conditions