From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Philippe BEAUDOIN <phb07(at)apra(dot)asso(dot)fr> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: proposal: schema variables |
Date: | 2019-12-30 20:05:40 |
Message-ID: | CAFj8pRA+SYbegM6f5OTamwhMdsVXB22mbmkscaErrhYge8ji3A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-performance |
Hi
po 30. 12. 2019 v 17:27 odesílatel Philippe BEAUDOIN <phb07(at)apra(dot)asso(dot)fr>
napsal:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: tested, failed
>
> Hi Pavel,
>
> I have tested the latest version of your patch.
> Both issues I reported are now fixed. And you largely applied my
> proposals. That's great !
>
> I have also spent some time to review more closely the documentation. I
> will send you a direct mail with an attached file for some minor comments
> on this topic.
>
> Except these documentation remarks to come, I haven't any other issue or
> suggestion to report.
> Note that I have not closely looked at the C code itself. But may be some
> other reviewers have already done that job.
> If yes, my feeling is that the patch could soon be set as "Ready for
> commiter".
>
> Best regards. Philippe.
>
> The new status of this patch is: Waiting on Author
>
Thank you very much for your comments, and notes. Updated patch attached.
Regards
Pavel
Attachment | Content-Type | Size |
---|---|---|
schema-variables-20191230.patch.gz | application/gzip | 66.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Treat | 2019-12-30 20:46:40 | Re: [PATCH] Increase the maximum value track_activity_query_size |
Previous Message | David Fetter | 2019-12-30 19:27:12 | Re: Recognizing superuser in pg_hba.conf |
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2020-01-03 14:14:27 | distinguish index cost component from table component |
Previous Message | Philippe BEAUDOIN | 2019-12-30 16:26:10 | Re: proposal: schema variables |