| From: | Philippe BEAUDOIN <phb07(at)apra(dot)asso(dot)fr> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: proposal: schema variables |
| Date: | 2019-12-30 16:26:10 |
| Message-ID: | 157772317031.1198.14690129684698137065.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: tested, failed
Hi Pavel,
I have tested the latest version of your patch.
Both issues I reported are now fixed. And you largely applied my proposals. That's great !
I have also spent some time to review more closely the documentation. I will send you a direct mail with an attached file for some minor comments on this topic.
Except these documentation remarks to come, I haven't any other issue or suggestion to report.
Note that I have not closely looked at the C code itself. But may be some other reviewers have already done that job.
If yes, my feeling is that the patch could soon be set as "Ready for commiter".
Best regards. Philippe.
The new status of this patch is: Waiting on Author
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-12-30 16:29:20 | Re: 12's AND CHAIN doesn't chain when transaction raised an error |
| Previous Message | Anastasia Lubennikova | 2019-12-30 15:57:06 | Re: Building infrastructure for B-Tree deduplication that recognizes when opclass equality is also equivalence |