Re: proposal: schema variables

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Philippe BEAUDOIN <phb07(at)apra(dot)asso(dot)fr>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: proposal: schema variables
Date: 2020-01-17 21:10:35
Message-ID: CAFj8pRCAGXK9Wd8FGboFkFyUTWwh0qJUKW0muVAMkAUq6feCdA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-performance

Hi

po 30. 12. 2019 v 21:05 odesílatel Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
napsal:

> Hi
>
> po 30. 12. 2019 v 17:27 odesílatel Philippe BEAUDOIN <phb07(at)apra(dot)asso(dot)fr>
> napsal:
>
>> The following review has been posted through the commitfest application:
>> make installcheck-world: tested, passed
>> Implements feature: tested, passed
>> Spec compliant: not tested
>> Documentation: tested, failed
>>
>> Hi Pavel,
>>
>> I have tested the latest version of your patch.
>> Both issues I reported are now fixed. And you largely applied my
>> proposals. That's great !
>>
>> I have also spent some time to review more closely the documentation. I
>> will send you a direct mail with an attached file for some minor comments
>> on this topic.
>>
>> Except these documentation remarks to come, I haven't any other issue or
>> suggestion to report.
>> Note that I have not closely looked at the C code itself. But may be some
>> other reviewers have already done that job.
>> If yes, my feeling is that the patch could soon be set as "Ready for
>> commiter".
>>
>> Best regards. Philippe.
>>
>> The new status of this patch is: Waiting on Author
>>
>
> Thank you very much for your comments, and notes. Updated patch attached.
>

rebase

> Regards
>
> Pavel
>
>

Attachment Content-Type Size
schema-variables-20200117.patch.gz application/gzip 66.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-01-17 21:12:16 Re: Reorderbuffer crash during recovery
Previous Message legrand legrand 2020-01-17 21:10:32 Re: Implementing Incremental View Maintenance

Browse pgsql-performance by date

  From Date Subject
Next Message Tomas Vondra 2020-01-21 23:41:41 Re: proposal: schema variables
Previous Message Cosmin Prund 2020-01-16 19:52:15 Re: Bad query plan decision when using multiple column index - postgresql uses only first column then filters