| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Document XLOG_INCLUDE_XID a little better |
| Date: | 2021-10-03 11:35:24 |
| Message-ID: | CAFiTN-vgDLbqEWenfsdD_wvDknVRVeSb3XoOVST_KJXnEgyy4A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Oct 2, 2021 at 8:10 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2021-Oct-02, Dilip Kumar wrote:
>
> > I have written two patches, Approach1 is as you described using a
> > static boolean and Approach2 as a local variable to XLogAssembleRecord
> > as described by Amit, attached both of them for your reference.
> > IMHO, either of these approaches looks cleaner.
>
> Thanks! I haven't read these patches carefully, but I think the
> variable is about assigning the *subxid*, not the topxid. Amit can
> confirm ...
IIRC, this variable is for logging the top xid in the first WAL by
each subtransaction. So that during logical decoding, while creating
the ReorderBufferTxn for the subtransaction we can associate it to the
top transaction without seeing the commit WAL.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-10-03 17:21:32 | pgsql: Fix checking of query type in plpgsql's RETURN QUERY command. |
| Previous Message | Peter Geoghegan | 2021-10-03 00:14:37 | pgsql: Enable deduplication in system catalog indexes. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2021-10-03 12:22:57 | Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |
| Previous Message | Magnus Hagander | 2021-10-03 10:23:33 | Re: 2021-09 Commitfest |