| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Document XLOG_INCLUDE_XID a little better |
| Date: | 2021-10-02 14:40:10 |
| Message-ID: | 202110021440.hepk6kcgtjzi@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2021-Oct-02, Dilip Kumar wrote:
> I have written two patches, Approach1 is as you described using a
> static boolean and Approach2 as a local variable to XLogAssembleRecord
> as described by Amit, attached both of them for your reference.
> IMHO, either of these approaches looks cleaner.
Thanks! I haven't read these patches carefully, but I think the
variable is about assigning the *subxid*, not the topxid. Amit can
confirm ...
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
"Aprender sin pensar es inútil; pensar sin aprender, peligroso" (Confucio)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-10-02 20:08:19 | pgsql: Update our mapping of Windows time zone names using CLDR info. |
| Previous Message | Dilip Kumar | 2021-10-02 10:46:31 | Re: pgsql: Document XLOG_INCLUDE_XID a little better |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-10-02 14:52:08 | Re: 2021-09 Commitfest |
| Previous Message | Fabien COELHO | 2021-10-02 14:31:04 | Re: psql - add SHOW_ALL_RESULTS option |