Re: refactoring basebackup.c

On Wed, May 13, 2020 at 1:56 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Tue, May 12, 2020 at 4:32 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> > Some of the bbsink_libpq_* functions are directly calling pq_* e.g.
> > bbsink_libpq_begin_backup whereas others are calling SendCopy*
> > functions and therein those are calling pq_* functions. I think
> > bbsink_libpq_* function can directly call pq_* functions instead of
> > adding one more level of the function call.
>
> I think all the helper functions have more than one caller, though.
> That's why I created them - to avoid duplicating code.

You are right, somehow I missed that part. Sorry for the noise.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com