| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2020-05-12 20:26:34 |
| Message-ID: | CA+Tgmoan5itkVtmbHi_2kiYSwT_JWWT8tyNAZTvsFVtW7D4Z6Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 12, 2020 at 4:32 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> Some of the bbsink_libpq_* functions are directly calling pq_* e.g.
> bbsink_libpq_begin_backup whereas others are calling SendCopy*
> functions and therein those are calling pq_* functions. I think
> bbsink_libpq_* function can directly call pq_* functions instead of
> adding one more level of the function call.
I think all the helper functions have more than one caller, though.
That's why I created them - to avoid duplicating code.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-05-12 20:27:26 | Re: Our naming of wait events is a disaster. |
| Previous Message | Alvaro Herrera | 2020-05-12 20:25:24 | Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql: Support FETCH FIRST WITH TIES) |