| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Correct comment in StartupXLOG(). |
| Date: | 2021-02-03 09:17:56 |
| Message-ID: | CAFiTN-v2o_JUz7PSdBMXxbMLBWG6Wzzxcysg3+3CTutR5hfKwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 3, 2021 at 2:28 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
> Hi,
>
> SharedRecoveryState member of XLogCtl is no longer a boolean flag, got changes
> in 4e87c4836ab9 to enum but, comment referring to it still referred as the
> boolean flag which is pretty confusing and incorrect.
+1 for the comment change
> Also, the last part of the same comment is as:
>
> " .. although the boolean flag to allow WAL is probably atomic in
> itself, .....",
>
> I am a bit confused here too about saying "atomic" to it, is that correct?
> I haven't done anything about it, only replaced the "boolean flag" to "recovery
> state" in the attached patch.
I don't think the atomic is correct, it's no more boolean so it is
better we get rid of this part of the comment
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2021-02-03 09:23:20 | DROP TABLE can crash the replication sync worker |
| Previous Message | tsunakawa.takay@fujitsu.com | 2021-02-03 09:15:03 | RE: POC: Cleaning up orphaned files using undo logs |