| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Correct comment in StartupXLOG(). |
| Date: | 2021-02-03 08:57:50 |
| Message-ID: | CAAJ_b97Hf+1SXnm8jySpO+Fhm+-VKFAAce1T_cupUYtnE3Nxig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
SharedRecoveryState member of XLogCtl is no longer a boolean flag, got changes
in 4e87c4836ab9 to enum but, comment referring to it still referred as the
boolean flag which is pretty confusing and incorrect.
Also, the last part of the same comment is as:
" .. although the boolean flag to allow WAL is probably atomic in
itself, .....",
I am a bit confused here too about saying "atomic" to it, is that correct?
I haven't done anything about it, only replaced the "boolean flag" to "recovery
state" in the attached patch.
Regards,
Amul
| Attachment | Content-Type | Size |
|---|---|---|
| fix_comment_in_StartupXLOG.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2021-02-03 09:03:29 | Re: POC: Cleaning up orphaned files using undo logs |
| Previous Message | japin | 2021-02-03 08:32:10 | Re: Support ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION ... syntax |