Re: OOM in spgist insert

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: OOM in spgist insert
Date: 2021-05-12 11:56:33
Message-ID: CAFiTN-ss4weC-qxV=UZxtAFzWDs6J_ZF3FEF9b9JahSGDHgUKg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 12, 2021 at 5:11 PM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
>>
>> V2 works. Thanks for fixing this quickly, I think you can add a
>> comment for the new error condition you added.
>
> Added comments. PFA v3

Thanks.

+ *
+ * For indexes with INCLUDEd columns we do not know whether we can reduce
+ * index tuple size by suffixing its key part or we will go into the
+ * endless loop on pick-split (in case included columns data is big enough

INCLUDEd -> why you have used a mixed case here?

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Borisov 2021-05-12 12:05:33 Re: OOM in spgist insert
Previous Message Pavel Borisov 2021-05-12 11:41:21 Re: OOM in spgist insert