Re: User management functionality patch [pgadmin4]

From: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: User management functionality patch [pgadmin4]
Date: 2016-05-31 06:42:57
Message-ID: CAFiP3vzcaCv+wjtX_PXrEROZhPvNq-Zr1C6kngxk1D3Ff3p-tQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

--
*Harshal Dhumal*
*Software Engineer *

EenterpriseDB <http://www.enterprisedb.com>

On Mon, May 30, 2016 at 4:09 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Harshal,
>
> PFA comments as below,
>
> 1) While running setup.py for the first time, We did not handle the case
> to create Standard user.
>
Fixed

> 2) Save button gets enable only clicking on input text box
>
Fixed

> 3) Remove delete button from sub-node
>
Removed button.

4) If current user changes its own name/email, main page should reflect new
> changes.
>
Moved to TODO

>
>
> Can be listed as TODO
> --------------------------------
> 1) Erros description is missing, for example when have user test(at)test(dot)com
> presnt and user try to add user same as test(at)test(dot)com we get error as
> "Error during saving user" it should be descriptive like "ERRPR: User {XYZ}
> is already exists.."
>
Fixed. (Added client side validation)

> 2) There should be an option to delete multiple users at one shot.
>
Moved to TODO

> 3) There should be an option to active/deactivate multiple users in one
> shot.
>
Moved to TODO

> 4) In-place editing in backgrid.
>
Moved to TODO

>
>
> Regards,
> Murtuza
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, May 27, 2016 at 7:02 PM, Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA initial patch for User management functionality.
>>
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB <http://www.enterprisedb.com>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-05-31 07:42:03 Re: User management functionality patch [pgadmin4]
Previous Message Harshal Dhumal 2016-05-31 06:40:04 Re: User management functionality patch [pgadmin4]