From: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgadmin4] Edb package support. |
Date: | 2016-08-22 14:23:42 |
Message-ID: | CAFiP3vyzARLrORJYop-o93fgA_u1AxNw0WfLwb_sZcJ6E0Ww5w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
--
*Harshal Dhumal*
*Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Aug 22, 2016 at 5:45 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Mon, Aug 22, 2016 at 1:04 PM, Harshal Dhumal
> <harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> > Hi,
> > PFA patch for wrong header and body were generated.
> >
> > Fixed the header and body sql parsing issue.
>
> Won't this break if I have a package called issues.foo or anything
> else that matches the ' is' or ' as'?
>
Yes, this causes issue. I have fixed it in updated patch.
Also fixed one more issue pointed by Khushboo, In some cases if we update
package header it drops package body. Ideally it should not drop body.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachment | Content-Type | Size |
---|---|---|
edb_package_sql_parse_issue_V2.patch | text/x-patch | 5.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-08-22 15:49:37 | pgAdmin 4 commit: Fix parsing issue in packages. |
Previous Message | Priyanka Shendge | 2016-08-22 12:42:51 | Re: pgAdmin IV : Unittest modular patch(database child nodes) and trigger function |