Re: [pgadmin4] Edb package support.

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
Cc: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin4] Edb package support.
Date: 2016-08-22 15:49:55
Message-ID: CA+OCxoxZ56qFAs0=97GK881Pi6C6o+4m1zEnMb1zxMMsAxeKyw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Mon, Aug 22, 2016 at 3:23 PM, Harshal Dhumal
<harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Aug 22, 2016 at 5:45 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Mon, Aug 22, 2016 at 1:04 PM, Harshal Dhumal
>> <harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>> > Hi,
>> > PFA patch for wrong header and body were generated.
>> >
>> > Fixed the header and body sql parsing issue.
>>
>> Won't this break if I have a package called issues.foo or anything
>> else that matches the ' is' or ' as'?
>
> Yes, this causes issue. I have fixed it in updated patch.
>
> Also fixed one more issue pointed by Khushboo, In some cases if we update
> package header it drops package body. Ideally it should not drop body.
>
>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-08-23 04:02:19 pgAdmin 4 commit: Cleanup old code in server_groups.js. Fixes #1247
Previous Message Dave Page 2016-08-22 15:49:37 pgAdmin 4 commit: Fix parsing issue in packages.