Re: Patch for pgagent RM1878 [pgAgent]

From: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch for pgagent RM1878 [pgAgent]
Date: 2016-10-24 06:27:18
Message-ID: CAFiP3vxtJXGO8xm9eDvH+jZj5_wzRTf2F_NQkOrYfnm5YhYODw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

I mean reverse engineered sql tab. Currently it's not implemented for both
pgagent schedule and jobs.

I have created Rm for that RM1891
<https://redmine.postgresql.org/issues/1891>

--
*Harshal Dhumal*
*Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Oct 21, 2016 at 8:30 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks - applied, with one change to *enable* the SQL tabs everywhere.
>
> On Fri, Oct 21, 2016 at 2:41 PM, Harshal Dhumal
> <harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA updated patch for RM1878
> >
> > Issues fixed:
> >
> > 1. ProgrammingError: can't adapt type 'Undefined' for schedule
> > 2. Fixed malformed array literal issue raised by postgres while creating
> > schedule
> > 3. Fixed update of schedule.
> > 4. Fixed update of step.
> > 5. disabled sql tab (create sql tab) for step.
> >
> > --
> > Harshal Dhumal
> > Software Engineer
> >
> > EnterpriseDB India: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> > On Fri, Oct 21, 2016 at 4:11 PM, Harshal Dhumal
> > <harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> >>
> >> Hi,
> >>
> >> Please ignore this patch as I haven't fixed same issue for schedule.
> Also
> >> there is issue "malformed array literal" when we try to save schedule.
> >>
> >> I'll be sending updated patch.
> >>
> >> Thanks Harshal,
> >>
> >> --
> >> Harshal Dhumal
> >> Software Engineer
> >>
> >> EnterpriseDB India: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >>
> >> On Fri, Oct 21, 2016 at 2:51 PM, Harshal Dhumal
> >> <harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> >>>
> >>> Hi,
> >>>
> >>> PFA attached patch for pgagent issue RM1878
> >>>
> >>> issue fixed: ProgrammingError: can't adapt type 'Undefined'
> >>>
> >>> --
> >>> Harshal Dhumal
> >>> Software Engineer
> >>>
> >>> EnterpriseDB India: http://www.enterprisedb.com
> >>> The Enterprise PostgreSQL Company
> >>
> >>
> >
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-10-24 08:04:14 Re: Patch for pgagent RM1878 [pgAgent]
Previous Message Dave Page 2016-10-21 15:46:31 Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL