Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL
Date: 2016-10-21 15:46:31
Message-ID: CA+OCxowo2158=USKZ1nFvpogA4BO2R3UcHHC6xWzSsiGOdj6eg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Oct 21, 2016 at 4:42 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> On Fri, Oct 21, 2016 at 8:52 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar
>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> > Hi
>> >
>> > This fix is for exclusion constraint.
>> > The options like "order" and "nulls" must be conditional. i.e. include
>> > only
>> > when access method type is other than "gist".
>>
>> When creating an index, the asc/desc options are disabled if gist/gin
>> used. I think they also should be here.
>>
>> Also, what about gin indexes in this case?
>
> As per documentation,
> The access method must support amgettuple (see Chapter 52); at present this
> means GIN cannot be used

OK, but this patch (unlike the last one) only seems to check for gist.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Harshal Dhumal 2016-10-24 06:27:18 Re: Patch for pgagent RM1878 [pgAgent]
Previous Message Surinder Kumar 2016-10-21 15:42:14 Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL