Fix for RM3027: Do not SQLQuote parameter values for objects

From: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Fix for RM3027: Do not SQLQuote parameter values for objects
Date: 2018-02-02 10:20:13
Message-ID: CAFiP3vwwZJkGfMrzYaU7XpB89HpafSgA-X4Jv4TguopQt-W50g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

If user wants to set parameter values which requires quote
(like string values which have space/s in it or have special symbol ($) )
then
he has to input this values with quotes. (See below example)

Also all parameter values are case insensitive and while storing these
values postgres
always store them in lower case (as per docs
<https://www.postgresql.org/docs/9.5/static/config-setting.html>). So
values which are in upper case won't need quotes.

Example:

*1. User input*

[image: Inline image 2]

*2. Generated SQL*

[image: Inline image 3]

3. *Generated SQL (after saving properties.)*

[image: Inline image 4]

--
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
RM3027.patch text/x-patch 2.2 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2018-02-02 12:51:39 [pgAdmin4][RM#3016] Properly display notices in case of error
Previous Message Khushboo Vashi 2018-02-02 07:23:07 Re: [pgAdmin4][Patch]: RM # 2895 - All the controls and display elements in the main window to be accessible using the tab key in an appropriate order