Re: Fix for RM3027: Do not SQLQuote parameter values for objects

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fix for RM3027: Do not SQLQuote parameter values for objects
Date: 2018-02-02 13:58:41
Message-ID: CA+OCxoxJq59W76iNcEos++LmvCi82m+mE8Q295LDWTwO+kcWNQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Fri, Feb 2, 2018 at 11:20 AM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:

> Hi,
>
> If user wants to set parameter values which requires quote
> (like string values which have space/s in it or have special symbol ($) )
> then
> he has to input this values with quotes. (See below example)
>
> Also all parameter values are case insensitive and while storing these
> values postgres
> always store them in lower case (as per docs
> <https://www.postgresql.org/docs/9.5/static/config-setting.html>). So
> values which are in upper case won't need quotes.
>
>
>
> Example:
>
> *1. User input*
>
> [image: Inline image 2]
>
> *2. Generated SQL*
>
> [image: Inline image 3]
>
> 3. *Generated SQL (after saving properties.)*
>
> [image: Inline image 4]
>
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-02-02 14:23:38 pgAdmin 4 commit: Ensure we capture notices raised by queries. Fixes #3
Previous Message Dave Page 2018-02-02 13:58:34 pgAdmin 4 commit: Don't quote variable values used by SET. It's usually