Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

Hi Dave,

On Tue, Jul 18, 2017 at 8:31 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Tue, Jul 18, 2017 at 2:40 PM, Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> On Tue, Jul 18, 2017 at 1:24 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>>
>>>
>>> On Tue, Jul 18, 2017 at 8:26 AM, Harshal Dhumal <
>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>>
>>>> On Mon, Jul 17, 2017 at 9:33 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Mon, Jul 17, 2017 at 1:09 PM, Harshal Dhumal <
>>>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find updated patch. Now placeholder string for bytea and
>>>>>> bytea[] data will only appear in datagrid (view all/1000/500 rows). If user
>>>>>> executes query using Query tool then placeholder won't appear (similar to
>>>>>> pgAdminIII behaviour)
>>>>>>
>>>>>
>>>>> I'm getting the following error when testing this:
>>>>>
>>>>
>>>> I ran all feature test cases 5-6 times and each time they ran
>>>> successfully.
>>>> May be this is occasional failure which we get after running test cases
>>>> for many times.
>>>>
>>>> Please let me know if you are getting this failure consistently at your
>>>> end.
>>>>
>>>
>>> I ran it twice and it failed twice. I can't keep running tests over and
>>> over again as they take quite a while to run and I can't use my machine for
>>> anything else at the same time as occasionally the test browser will grab
>>> focus.
>>>
>>
>> Please find updated patch.
>> I have slightly modified feature test case for 'view data dml queries'
>> (though I wasn't getting failure as mentioned).
>>
>>
> Thanks, that passes.
>
> Now I've played with it though, I think that the query tool should also
> hide the binary data. I don't see a good reason to see it in one place but
> not another - ultimately it's still not human readable.
>
> Also, we need to make it look like the [null] placeholder I think; e.g.
> use [ ] instead of < > and give it a lighter colour.
>
> Please find updated patch. I have fixed all of above review comments.

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>