From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
Cc: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid |
Date: | 2017-07-20 12:02:52 |
Message-ID: | CA+OCxoywu7u8q=ayXs1b=UeDO2SCAYe0FzYqyOo-jVANxV8aTg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Wed, Jul 19, 2017 at 1:58 PM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> On Tue, Jul 18, 2017 at 8:31 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>
>> Thanks, that passes.
>>
>> Now I've played with it though, I think that the query tool should also
>> hide the binary data. I don't see a good reason to see it in one place but
>> not another - ultimately it's still not human readable.
>>
>> Also, we need to make it look like the [null] placeholder I think; e.g.
>> use [ ] instead of < > and give it a lighter colour.
>>
>> Please find updated patch. I have fixed all of above review comments.
>
Hmm, not that I can see. See the attached screenshot - I'm getting "binary
data" in black, not "[binary data]" in grey (to match [null]).
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
Screen Shot 2017-07-20 at 13.00.32.png | image/png | 113.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-07-20 12:04:41 | Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid |
Previous Message | Dave Page | 2017-07-20 11:52:19 | pgAdmin 4 commit: More webpack cleanup - add comments liberally and ren |