Re: Add regression tests for DISCARD

From: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
To: Robins Tharakan <tharakan(at)gmail(dot)com>
Cc: Marko Kreen <markokr(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add regression tests for DISCARD
Date: 2013-07-02 14:32:37
Message-ID: CAFcNs+qb2zKC9Wu=hBaUUbT+wu7qZ=VuMPRaHamW6CTPLX=6bQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 1, 2013 at 5:59 PM, Robins Tharakan <tharakan(at)gmail(dot)com> wrote:

>
> Thanks Marko for pointing out about guc.sql.
>
> Please find attached a patch to move DISCARD related tests from guc.sql to
> discard.sql. It adds an extra test for a DISCARD PLANS line, although I
> amn't sure on how to validate that its working.
>
> Personally, I wouldn't call this a great patch, since most of the tests
> were already running, although in a generic script. The separation of
> DISCARD related tests to another file is arguably good for the long-term
> though.
>

Robins,

You must add this new test case called "discard" to
src/test/regress/parallel_schedule and src/test/regress/serial_schedule,
because if we do "make check" the new "discard" test case is not executed.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2013-07-02 14:36:34 Re: Large object + FREEZE?
Previous Message Robert Haas 2013-07-02 14:17:08 Re: New regression test time