Re: Add regression tests for DISCARD

From: Robins Tharakan <tharakan(at)gmail(dot)com>
To: Marko Kreen <markokr(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add regression tests for DISCARD
Date: 2013-07-01 20:59:03
Message-ID: CAEP4nAwW-tPaBKhr9-E2_Vk_3oj5X6Uy5JkEHj_niuTmQNt3cA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 17 June 2013 18:14, Marko Kreen <markokr(at)gmail(dot)com> wrote:

> Perhaps existing tests in guc.sql should be merged into it?
>
>
Thanks Marko for pointing out about guc.sql.

Please find attached a patch to move DISCARD related tests from guc.sql to
discard.sql. It adds an extra test for a DISCARD PLANS line, although I
amn't sure on how to validate that its working.

Personally, I wouldn't call this a great patch, since most of the tests
were already running, although in a generic script. The separation of
DISCARD related tests to another file is arguably good for the long-term
though.

--
Robins Tharakan

Attachment Content-Type Size
regress_discard_v3.patch application/octet-stream 8.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-07-01 21:03:22 Re: pg_resetxlog -m documentation not up to date
Previous Message Peter Eisentraut 2013-07-01 20:41:49 Re: proposal: simple date constructor from numeric values