| From: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, "[pgdg] Robert Haas" <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [UNVERIFIED SENDER] Re: Minimal logical decoding on standbys |
| Date: | 2021-01-25 19:34:17 |
| Message-ID: | CAFcNs+qWENuzW1Re8A=7FMRMOoiwW3qRKJqXeuTYSgVJE7qxeg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 18, 2021 at 8:48 AM Drouvot, Bertrand <bdrouvot(at)amazon(dot)com>
wrote:
>
> 3 and 4 were failing because the
ResolveRecoveryConflictWithLogicalSlots() call was missing in
ResolveRecoveryConflictWithSnapshot(): the new version attached adds it.
>
> The new version attached also provides a few changes to make it compiling
on the current master (it was not the case anymore).
>
> I also had to change 023_standby_logical_decoding_conflicts.pl (had to
call $node_standby->create_logical_slot_on_standby($node_master,
'otherslot', 'postgres'); at the very beginning of the "DROP DATABASE
should drops it's slots, including active slots" section)
>
Awesome and thanks a lot.
Seems your patch series is broken... can you please `git format-patch` and
send again?
Regards,
--
Fabrízio de Royes Mello
PostgreSQL Developer at OnGres Inc. - https://ongres.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-01-25 19:36:21 | Re: Fixing cache pollution in the Kerberos test suite |
| Previous Message | Jacob Champion | 2021-01-25 19:31:16 | Re: Fixing cache pollution in the Kerberos test suite |