Re: Fixing cache pollution in the Kerberos test suite

From: Jacob Champion <pchampion(at)vmware(dot)com>
To: "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net>
Subject: Re: Fixing cache pollution in the Kerberos test suite
Date: 2021-01-25 19:31:16
Message-ID: 6933ad07afc4c8325059eb9c40ec213fa40adf35.camel@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2021-01-25 at 14:04 -0500, Tom Lane wrote:
> Jacob Champion <pchampion(at)vmware(dot)com> writes:
> > On Mon, 2021-01-25 at 13:49 -0500, Tom Lane wrote:
> > > Also, why are you only setting the ENV variable within narrow parts
> > > of the test script? I'd be inclined to enforce it throughout.
> > I considered it and decided I didn't want to pollute the server's
> > environment with it, since the server shouldn't need the client cache.
>
> True, but if it did try to access the cache, accessing the user's
> normal cache would be strictly worse than accessing the test cache.

That's fair. Attached is a v2 that just sets KRB5CCNAME globally. Makes
for a much smaller patch :)

--Jacob

Attachment Content-Type Size
v2-test-kerberos-use-a-local-credentials-cache.patch text/x-patch 1.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabrízio de Royes Mello 2021-01-25 19:34:17 Re: [UNVERIFIED SENDER] Re: Minimal logical decoding on standbys
Previous Message Bruce Momjian 2021-01-25 19:18:05 Re: Key management with tests