| From: | Alex Hunsaker <badalex(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix. |
| Date: | 2012-01-14 00:09:17 |
| Message-ID: | CAFaPBrQ3pe8ft_VAZaQUoxLp-zQ7MnOE4XqVaZPJ1dR1sYdTbw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Jan 13, 2012 at 16:07, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 01/12/2012 09:28 PM, Alex Hunsaker wrote:
>>
>> Util.c/o not depending on plperl_helpers.h was also throwing me for a loop
>> so I fixed it and SPI.c... Thoughts?
>
>
> Basically looks good, but I'm confused by this:
>
> do language plperl $$ elog('NOTICE', ${^TAINT}); $$;
>
>
>
> Why is NOTICE quoted here? It's constant that we've been careful to set up.
No reason.
[ Err well It was just part of me flailing around while trying to
figure out why elog was still crashing even thought I had the issue
fixed. The real problem was Util.o was not being recompiled due to
Util.c not depending on plperl_helpers.h) ]
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2012-01-14 13:02:28 | pgsql: initdb: Remove support for crypt authentication method |
| Previous Message | Andrew Dunstan | 2012-01-13 23:07:43 | Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-01-14 00:17:43 | Re: Remembering bug #6123 |
| Previous Message | Kevin Grittner | 2012-01-13 23:18:50 | Re: Remembering bug #6123 |