Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alex Hunsaker <badalex(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.
Date: 2012-01-13 23:07:43
Message-ID: 4F10B93F.2080008@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 01/12/2012 09:28 PM, Alex Hunsaker wrote:
> Util.c/o not depending on plperl_helpers.h was also throwing me for a
> loop so I fixed it and SPI.c... Thoughts?

Basically looks good, but I'm confused by this:

do language plperl $$ elog('NOTICE', ${^TAINT}); $$;

Why is NOTICE quoted here? It's constant that we've been careful to set up.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alex Hunsaker 2012-01-14 00:09:17 Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.
Previous Message Alvaro Herrera 2012-01-13 18:46:10 Re: pgsql: Typo fix.

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2012-01-13 23:18:50 Re: Remembering bug #6123
Previous Message Tomas Vondra 2012-01-13 23:07:02 Re: Review of: explain / allow collecting row counts without timing info