From: | Yosry Muhammad <yosrym93(at)gmail(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Bug in Database Nodes in the Tree |
Date: | 2019-07-23 08:56:54 |
Message-ID: | CAFSMqn_dSLC1CUgPpYX3czsCwr37ZL8uvt5dOBDzk-JGD+tGnw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks for making things clear.
On Tue, Jul 23, 2019, 10:01 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> On Tue, Jul 23, 2019 at 4:15 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Tue, Jul 23, 2019 at 2:17 AM Yosry Muhammad <yosrym93(at)gmail(dot)com>
>> wrote:
>>
>>> Hi,
>>>
>>> I tried just removing the lines responsible for connecting to the
>>> database on selecting a database node and it seem to work fine.
>>> Specifically the lines 254-257 in database.js (callbacks.selected function).
>>>
>>> Are there any specific scenarios I need to test to make sure everything
>>> is okay? Anywhere else in the code where I need to make changes?
>>>
>>> I think all the right side panels (i.e. Properties, SQL, etc...) will be
>> affected.
>>
>
> They're populated on select. It may mean that we have to show a "Please
> connect to the server" message in them, if a database or server is selected
> but not connected.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
From | Date | Subject | |
---|---|---|---|
Next Message | Devrim Gündüz | 2019-07-23 13:48:43 | Re: pgAdmin4 v4.11 candidate builds |
Previous Message | Daniel Gustafsson | 2019-07-23 08:13:00 | Fix projection of pg_type for Greenplum query |