From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Cc: | Yosry Muhammad <yosrym93(at)gmail(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Bug in Database Nodes in the Tree |
Date: | 2019-07-23 08:01:13 |
Message-ID: | CA+OCxowEOHKTWWb59UzJ5o338OaUGwLR7+SyX0cPbb3+F2rAYg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Tue, Jul 23, 2019 at 4:15 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>
> On Tue, Jul 23, 2019 at 2:17 AM Yosry Muhammad <yosrym93(at)gmail(dot)com> wrote:
>
>> Hi,
>>
>> I tried just removing the lines responsible for connecting to the
>> database on selecting a database node and it seem to work fine.
>> Specifically the lines 254-257 in database.js (callbacks.selected function).
>>
>> Are there any specific scenarios I need to test to make sure everything
>> is okay? Anywhere else in the code where I need to make changes?
>>
>> I think all the right side panels (i.e. Properties, SQL, etc...) will be
> affected.
>
They're populated on select. It may mean that we have to show a "Please
connect to the server" message in them, if a database or server is selected
but not connected.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2019-07-23 08:13:00 | Fix projection of pg_type for Greenplum query |
Previous Message | Ganesh Jaybhay | 2019-07-23 05:44:47 | [pgAdmin][RM4490] Checkbox doesn't highlight on focus in IE11 |