| From: | Yosry Muhammad <yosrym93(at)gmail(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [GSoC] Query History Integration with updatable query resultsets and improvements |
| Date: | 2019-08-07 02:36:36 |
| Message-ID: | CAFSMqn_c84hufy8OJASCLM5B6REPivwSmBX+37rCp4U=cu2NyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
On Tue, Aug 6, 2019, 6:46 PM Yosry Muhammad <yosrym93(at)gmail(dot)com> wrote:
> Hi,
>
> On Tue, Aug 6, 2019, 6:01 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> Seems to work well :-). A few comments:
>>
>> - Should we have an icon by the non-generated queries (the lightning
>> flash) and the COMMITs etc (the commit/rollback icon as appropriate) as
>> well? I think just having the icon for generated queries looks a little odd.
>>
>
> I am sorry I don't quite understand. Do you mean having an icon to
> show/hide user queries as well? I believe a checkbox is more appropriate
> anyway, maybe placed right above the history entries. I am going to need a
> design of the checkbox or styling guidlines though.
>
Another idea that came to my mind is to use a dropdown menu checkbox just
next to the save data icon. Similar to auto-commot and auto-rollback
checkboxs in the dropdown menu next to the execute (flash) icon. What do
you think is better? This, or a checkbox right above the history entries?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aditya Toshniwal | 2019-08-07 05:18:47 | Re: [pgAdmin][RM4554] RE-SQL for trigger functions |
| Previous Message | Yosry Muhammad | 2019-08-06 16:46:15 | Re: [GSoC] Query History Integration with updatable query resultsets and improvements |