| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Jan Wieck <jan(at)wi3ck(dot)info>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Subject: | Re: Conflict Detection and Resolution |
| Date: | 2024-10-08 08:42:57 |
| Message-ID: | CAFPTHDZzf0wWd9DP5Sp1hPf2JL1HJ-q+4=X7U8bH_ommj6ToDQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 2, 2024 at 6:55 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> Hi, here are my code/test review comments for patch v14-0001.
>
>
>
Here is v15 patch (patch-0001), addressing comments from [1], [2], [3],
[4], [5] and [6].
Thanks Nisha for addressing comments in pg_dump.c and the sgml files.
In [6] - I've not addressed the suggestion to change the \dRS+ output to
display conflict resolvers as a table footer. I will post that in the next
patch.
I've tried to implement all the changes in the nitpick patch in [6],
although I couldn't apply the patch directly as I had made too many changes
by then. If I've missed something, let me know.
We will target comments post Sep30 as well as the rest of the patches in
the next update.
regards,
Ajin Cherian
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v15-0001-Add-CONFLICT-RESOLVERS-into-the-syntax-for-CREAT.patch | application/octet-stream | 128.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2024-10-08 08:55:12 | Re: Make default subscription streaming option as Parallel |
| Previous Message | Sutou Kouhei | 2024-10-08 08:39:18 | Re: Make COPY format extendable: Extract COPY TO format implementations |