| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <akapila(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command |
| Date: | 2021-06-09 10:46:13 |
| Message-ID: | CAFPTHDYfSf7KwuE2imzeRHt6Km5CYh9z=cxqPf0YHT6CG0=sig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 9, 2021 at 6:23 AM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> On Tue, 2021-06-08 at 17:41 +1000, Ajin Cherian wrote:
> > Here's an updated patchset that adds back in the option for two-phase
> > in CREATE_REPLICATION_SLOT command and a second patch that adds
> > support for
> > two-phase decoding in pg_recvlogical.
>
> A few things:
>
> * I suggest putting the TWO_PHASE keyword after the LOGICAL keyword
> * Document the TWO_PHASE keyword in doc/src/sgml/protocol.sgml
> * Cross check that --two-phase is specified only if --create-slot is
> specified
> * Maybe an Assert(!(two_phase && is_physical)) in
> CreateReplicationSlot()?
>
> Other than that, it looks good, and it works as I expect it to.
Updated. Do have a look.
thanks,
Ajin Cherian
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0002-Add-support-for-two-phase-decoding-in-pg_recvlogi.patch | application/octet-stream | 9.7 KB |
| v3-0001-Add-option-to-set-two-phase-in-CREATE_REPLICATION.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-06-09 10:50:49 | Re: postgres_fdw batching vs. (re)creating the tuple slots |
| Previous Message | Dilip Kumar | 2021-06-09 10:42:34 | Re: Decoding speculative insert with toast leaks memory |