| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <akapila(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command |
| Date: | 2021-06-08 20:23:45 |
| Message-ID: | 97a05433ccfbbdab1e3719be14272bdb790cf65a.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2021-06-08 at 17:41 +1000, Ajin Cherian wrote:
> Here's an updated patchset that adds back in the option for two-phase
> in CREATE_REPLICATION_SLOT command and a second patch that adds
> support for
> two-phase decoding in pg_recvlogical.
A few things:
* I suggest putting the TWO_PHASE keyword after the LOGICAL keyword
* Document the TWO_PHASE keyword in doc/src/sgml/protocol.sgml
* Cross check that --two-phase is specified only if --create-slot is
specified
* Maybe an Assert(!(two_phase && is_physical)) in
CreateReplicationSlot()?
Other than that, it looks good, and it works as I expect it to.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-06-08 20:37:07 | Re: Race condition in recovery? |
| Previous Message | Tom Lane | 2021-06-08 20:08:56 | Re: Make unlogged table resets detectable |