Re: [pgAdmin4] [Patch]: Foreign Table Module

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4] [Patch]: Foreign Table Module
Date: 2016-02-24 09:27:46
Message-ID: CAFOhELfm9y9jQLLzvnQpKey5TX=yZkL+qaF=6g+CsvuWKFDh2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

I have updated the Foreign Table module as below:

- Used 'NodeByListControl' to get schemas, in the foreign_table.js file as
suggested by Ashesh to avoid code redundancy.

- Applied *'Security Label Macro'* Patch (Implemented by Harshal).
To test the Foreign Table patch, 'Security Label Macro' patch must be
applied first as that is not committed yet.

Please find attached Foreign Table Patch.

Thanks,
Khushboo

On Tue, Feb 23, 2016 at 6:53 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find attached patch for the Foreign Table Module.
>
> The patch will be modified after Types module implementation as we need to
> populate Base Type and some Type related validations from the Types module.
>
> Please review it and let me know the feedback.
>
> Thanks,
> Khushboo
>

Attachment Content-Type Size
Foreign_table_ver_1.patch text/x-patch 102.6 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-02-24 09:31:12 pgAdmin 4 commit: Resolved a typo in the node creation SQL template for
Previous Message Khushboo Vashi 2016-02-24 09:24:25 Re: pgAdmin4 PATCH: Domain Module