| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history and related tests to remove dependency on React |
| Date: | 2019-03-07 11:01:49 |
| Message-ID: | CAFOhELfXHo-YdOqnyUkX1Mi2EDObDi+yNhwwU36rDt6g-N_Pcw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Thu, Mar 7, 2019 at 4:23 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Thanks - committed. Oddly, having removed a bunch of files and 88 JS
> dependencies, the resulting Python package is actually slightly bigger!
>
And now I have conflicts in around 40 files. :)
>
> On Thu, Mar 7, 2019 at 9:46 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to remove React dependency in pgAdmin.
>> The query history component is re-written using jQuery and vanilla JS.
>> There is no change in look and feel. Test cases are modified accordingly.
>> Perform a "yarn install" before bundling.
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2019-03-07 11:04:05 | Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history and related tests to remove dependency on React |
| Previous Message | Akshay Joshi | 2019-03-07 10:53:40 | pgAdmin 4 v4.3 released |