Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history and related tests to remove dependency on React

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history and related tests to remove dependency on React
Date: 2019-03-07 10:53:37
Message-ID: CA+OCxowX5uqy1kKc3B50H3e+4AkWcCWrQoQhfPieKE31arnVpA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - committed. Oddly, having removed a bunch of files and 88 JS
dependencies, the resulting Python package is actually slightly bigger!

On Thu, Mar 7, 2019 at 9:46 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to remove React dependency in pgAdmin.
> The query history component is re-written using jQuery and vanilla JS.
> There is no change in look and feel. Test cases are modified accordingly.
> Perform a "yarn install" before bundling.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-03-07 10:53:40 pgAdmin 4 v4.3 released
Previous Message Dave Page 2019-03-07 10:52:05 pgAdmin 4 commit: Remove the large and unnecessary dependency on React