From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and add support procedure for PG v11 |
Date: | 2018-06-12 07:09:48 |
Message-ID: | CAFOhELfWXEyeauH_SgVvWBEtKxTqRFyDCUY8Jvr7qnGUfN=F9A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
Please find the attached updated patch.
On Fri, Jun 8, 2018 at 2:21 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Thu, Jun 7, 2018 at 11:27 AM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please ignore my previous patch, find the attached updated one.
>>
>
> I found a couple of issues with this:
>
> - Clicking the + button on the Parameters tab does nothing in either
> Create or Edit modes
>
> Fixed
> - The debugger fails to start (though, perhaps that's because the plugin
> doesn't have Ashesh's latest patches in it).
>
> FYI, I was trying to test the debugger with:
>
> -- PROCEDURE: public.dummy_proc(integer)
>
> -- DROP PROCEDURE public.dummy_proc(integer);
>
> CREATE OR REPLACE PROCEDURE public.dummy_proc(
> id integer)
> LANGUAGE 'plpgsql'
>
> AS $BODY$BEGIN
> raise notice 'id is %', id;
> END;$BODY$;
>
> Fixed. Tested with the latest code of the plugin.
> Thanks!
>
> Thanks,
Khushboo
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachment | Content-Type | Size |
---|---|---|
RM_3362_ver2.patch | text/x-patch | 104.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Khushboo Vashi | 2018-06-12 10:24:53 | Re: [pgadmin4][Patch]: Test cases for the backup module |
Previous Message | Ashesh Vashi | 2018-06-12 05:34:51 | Re: [pgadmin4][patch][GreenPlum] Display SQL for tables takes 15 minutes to execute |