Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and add support procedure for PG v11

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and add support procedure for PG v11
Date: 2018-06-08 08:51:34
Message-ID: CA+OCxowGMOcrHAv4Q4PSu58PjQV3DfYtRuvba6wg-G_27uMjhA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Thu, Jun 7, 2018 at 11:27 AM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please ignore my previous patch, find the attached updated one.
>

I found a couple of issues with this:

- Clicking the + button on the Parameters tab does nothing in either Create
or Edit modes

- The debugger fails to start (though, perhaps that's because the plugin
doesn't have Ashesh's latest patches in it).

FYI, I was trying to test the debugger with:

-- PROCEDURE: public.dummy_proc(integer)

-- DROP PROCEDURE public.dummy_proc(integer);

CREATE OR REPLACE PROCEDURE public.dummy_proc(
id integer)
LANGUAGE 'plpgsql'

AS $BODY$BEGIN
raise notice 'id is %', id;
END;$BODY$;

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-06-08 09:08:42 Re: [pgadmin4][Patch]: Test cases for the backup module
Previous Message Dave Page 2018-06-08 07:45:14 Re: [patch] Minor shutdown message grammar fix