Re: Some pgAdmin bugs...

On Tue, Sep 10, 2019 at 5:33 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

>
>
> On Tue, Sep 10, 2019 at 5:29 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> On Tue, Sep 10, 2019 at 5:13 PM Arni Kromić <arni(dot)kromic(at)bios-ict(dot)hr>
>> wrote:
>>
>>> Working with pgAdmin, I've found several bugs. Not sure if they are
>>> already reported; couldn't find them on Redmine, but perhaps I missed them.
>>> Maybe someone will recognize if they've already been reported. Here it
>>> goes...
>>>
>>> 1) When doing View/Edit on an empty table, I cannot insert anything when
>>> it opens. There is no empty row I can write into, like there is when a
>>> table has at least one row already. In fact, there are no rows at all, just
>>> the header.
>>>
>> I tried. I get an empty row to enter
>> [image: Screenshot 2019-09-10 at 17.25.25.png]
>>
>>
> If the table doesn't have primary key, then empty row will **NOT** be
> there.
>
>>
>>> 2) Create Sequence dialog doesn't accept negative values for Increment
>>> (Error msg:
>>> Increment' must be greater than or equal to 1.) Postgres does accept
>>> negative increment, so should this dialog.
>>>
>> Kindly raise here -
>> https://redmine.postgresql.org/projects/pgadmin4/issues/new
>>
>>>
>>> 3) EXEC Script context menu for Procedures works incorrectly - doesn't
>>> write the script to the end. An example, procedure with many parameters:
>>>
>> Its a bug - Kindly raise here -
>> https://redmine.postgresql.org/projects/pgadmin4/issues/new
>>
>>> CREATE OR REPLACE PROCEDURE public.dodaj_klijenta(
>>> v_naziv character varying,
>>> v_oib character varying,
>>> v_pdv_id character varying,
>>> v_adresa character varying,
>>> v_mjesto integer,
>>> v_drzava character varying,
>>> v_tip_p_sub character varying,
>>> v_vlasnik character varying,
>>> v_pdv boolean,
>>> v_fisk boolean,
>>> v_iban character varying,
>>> v_k_osoba character varying,
>>> v_email character varying,
>>> v_br_tel character varying,
>>> v_radna_god numeric,
>>> v_schema character varying)
>>> ...
>>>
>>> The EXEC Script for it is generated exactly thus:
>>>
>>> CALL public.dodaj_klijenta(
>>> <v_naziv character varying>,
>>> <v_oib character varyi>
>>>
>>> As you can see, it is cut off very early.
>>> A notice, this is only for procedures; EXEC Scripts for functions with
>>> many arguments work fine.
>>>
>>> 4) This one is not a biggie, but it would be nice if it is fixed. Code
>>> inserted in the Code tab of the Create/Properties dialog for functions and
>>> procedures is put within $BODY$ tags without any newlines. So, if I write a
>>> new function/procedure and write this in the editor on the Code tab (shown
>>> together with line numbers I see):
>>>
>> Yes. Its been logged - https://redmine.postgresql.org/issues/3851
>>
>>> 1 select * from keyring
>>> 2 --some comment
>>>
>>> The function is created containing this:
>>>
>>> ...
>>> AS $BODY$select * from keyring
>>> --tralala$BODY$;
>>> ...
>>>
>>>
>>> Although it apparently doesn't harm the code, it is visually ugly and
>>> the syntax-highlighting colors the second line as comment, so the closing
>>> $BODY$ appears commented (a bit confusing to see). So to make it look
>>> normal, I have to prepend and append a newline:
>>>
>>> 1
>>> 2 select * from keyring
>>> 3 --some comment
>>> 4
>>>
>>> ...to get a more acceptable code:
>>>
>>> ...
>>> AS $BODY$
>>> select * from keyring
>>> --tralala
>>> $BODY$;
>>> ...
>>>
>>> So I propose those newlines should be added automatically.
>>>
>>>
>>> Please advise if I need to report the above problems on Redmine, or
>>> perhaps do something else...
>>>
>>> --
>>> Kind Regards,
>>> Arni Kromić
>>>
>>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>