Re: [Patch] - Housekeeping #7315 - Update pgAdmin4 doc for Traefikv2 containerization

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [Patch] - Housekeeping #7315 - Update pgAdmin4 doc for Traefikv2 containerization
Date: 2022-06-06 06:16:53
Message-ID: CAFOhELeNp55ojU-x8R1zbuzvr91Puj3Lsm-a5rq1X3WAQ_6LdA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Yogesh,

Review comments:

- Step 2: The below statements should be in a different line, like
- "Azure CLI" will use the currently logged in identity through Azure
CLI on the local machine.
- "Interactive Browser" opens a browser to authenticate a user
interactively.
- Disable the next button once authentication is complete.
- Cluster name availability call calls the server on every field change
- Availability zone needs description
- Add High availability option

Code:

- check_cluster_name_availability should be using the GET method instead
of Post
- Fix SonarLint issues
- Do we need the cache_persistence_options as it will create the
persistent storage which we do not require I guess?
- Why do we need to call _get_azure_credentials on every request? Can't
we store it in the session object?
- Use gettext wherever required in the js file

Thanks,
Khushboo

On Thu, Jun 2, 2022 at 3:07 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find the attached patch which updates documentation for Traefik v2
> container deployment.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2022-06-06 07:40:47 Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure
Previous Message Akshay Joshi 2022-06-03 07:26:04 Re: [pgAdmin][RM7351]: Templates not displayed