Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

Hi Dave,

Thanks for reviewing the patch.

On Thu, Nov 16, 2017 at 7:42 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Thu, Nov 16, 2017 at 10:01 AM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch for RM #2781 : New option to set the
>> quotation mark for copying to clipboard.
>>
>> This patch includes:
>>
>> - Provide options in preferences to control the CSV output which includes
>> copy to clipboard and download as CSV features in Query Tool
>> - Modified related jasmine tests
>> - Modified related feature tests
>>
>
> Thanks. At first glance, I see a few issues with this patch:
>
> - I can type into the combo boxes in the preferences, but only to search.
> That means (for example) that the only quote character I can use is ". I
> can't use anything else as a might want. The same applies to the field
> separator.
>
> - I can click the x to clear the options in the combo boxes, but then the
> settings can be accepted and stored. For the separator and quote char, I
> assume they just become blank, however the quoting method makes no sense to
> be unspecified.
>
> Will fix above issues.

> - There don't seem to be any documentation updates.
>
> Will do.

> - The CSV Quoting options appear to apply to copying from the grid, but
> they should apply to saving results as CSV.
>
>
All 3 CSV options are applicable for both, copying from grid and download
as CSV as I understood this way.
I had a doubt regarding this and have asked regarding this in the ticket
but didn't get reply, so implemented this way.
Now I understood correctly, so will change accordingly.

> - The Result Copy quoting options (which should apply to copied data) are
> missing altogether.
>
> To be clear, there should be 6 new config options, 3 of which apply to
> data when copied from the grid, and the other 3 which apply when saving
> data as CSV. Please see the original RM case in which I detailed what the
> settings should be and what they should do.
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Thanks,
Khushboo