| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for Check Constraint node |
| Date: | 2019-07-16 11:01:24 |
| Message-ID: | CAFOhELdj7mzZZsLCArB-UM+aJ9c_iywg1i0zSNgbDvYvBgL7rg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Dave,
On Tue, Jul 16, 2019 at 2:05 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Tue, Jul 16, 2019 at 7:22 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch for the RE-SQL and modified SQL tests for
>> check constraint node.
>>
>> For the table child nodes, *create table endpoint *with proper data is
>> required in the JSON file.
>> I have introduced one new parameter named *store_table_id* in the table
>> create endpoint, so the created table ID will be stored for the rest of the
>> scenarios
>>
>
> This breaks the type tests :-(
>
> Fixed.
Please find the attached updated patch.
Thanks,
Khushboo
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| Attachment | Content-Type | Size |
|---|---|---|
| resql_check_constraint_v1.patch | application/octet-stream | 6.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2019-07-16 13:36:32 | pgAdmin 4 commit: Fix typo |
| Previous Message | Dave Page | 2019-07-16 08:35:37 | Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for Check Constraint node |