From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for Check Constraint node |
Date: | 2019-07-17 12:25:23 |
Message-ID: | CA+OCxoxnSk6fVehiuFHTHMVO6et9rRszaZHz6t+3q9LG70t+nA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Tue, Jul 16, 2019 at 12:01 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> On Tue, Jul 16, 2019 at 2:05 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Tue, Jul 16, 2019 at 7:22 AM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch for the RE-SQL and modified SQL tests for
>>> check constraint node.
>>>
>>> For the table child nodes, *create table endpoint *with proper data is
>>> required in the JSON file.
>>> I have introduced one new parameter named *store_table_id* in the table
>>> create endpoint, so the created table ID will be stored for the rest of the
>>> scenarios
>>>
>>
>> This breaks the type tests :-(
>>
>> Fixed.
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2019-07-17 12:35:04 | Subtle test problem |
Previous Message | Dave Page | 2019-07-17 12:25:11 | pgAdmin 4 commit: Add Reverse Engineered SQL tests for Constraints. Fix |