Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes
Date: 2019-04-08 08:50:05
Message-ID: CAFOhELdhxyXNa_QCTFP-T38gb9MoW_DP+D3cHqGJUOdSgrPSjA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find the attached updated patch.

Thanks,
Khushboo

On Fri, Apr 5, 2019 at 11:32 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Khushboo
>
> #3605 is fixed and found below issue in #2392
>
> - As per steps given in RM, I have perform the same. But when I delete
> the row, delete button is still enabled and save button is disabled even
> though newly created row is still there. Apart from that code looks good to
> me. Please fix it.
>
>
> Fixed.

> On Thu, Apr 4, 2019 at 5:27 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix:
>>
>> 1. #3605 - Edit Data: Deleting N number of rows makes first N number of
>> rows disable
>> 2. #2392 - Datagrid: If we delete any row it also saves newly added row
>>
>> Thanks,
>> Khushboo
>>
>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

Attachment Content-Type Size
RM_3605_2392_v1.patch application/octet-stream 4.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-04-08 09:47:35 Re: GSoC Student - Help needed
Previous Message Dave Page 2019-04-08 08:36:31 Re: Async queries pretending to be synchronous