Re: [pgAdmin4][Patch]: Fixed RM #2779 - Lost field size

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Fixed RM #2779 - Lost field size
Date: 2017-12-11 12:46:01
Message-ID: CAFOhELd_x--LdOuykoYnGAyb+U29ch-ZOdcZnZ3ed=az_utCvQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Dec 11, 2017 at 6:03 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

>
>
> On Mon, Dec 11, 2017 at 5:45 PM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Mon, Dec 11, 2017 at 5:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> On Wed, Dec 6, 2017 at 5:45 AM, Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch to fix RM #2779: Lost field size.
>>>>
>>>> While editing the table column, if we change collate then, the length
>>>> and the precision are lost.
>>>> Also, while changing column type, it does not honour the length and
>>>> precision.
>>>>
>>>
>>> Now it loses the collation if you edit the length.
>>>
>>> Fixed.
Please find the attached patch.

> I have tested it, it's not loosing the collation.
>> Please let me know the steps to reproduce this.
>>
> Reproduced. Will send the patch.
>
>> :-(
>>>
>>>
>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>

Attachment Content-Type Size
RM_2779_ver1.patch text/x-patch 10.6 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Susan Douglas 2017-12-11 17:39:11 pgAdmin 4 - Update for Preferences dialog
Previous Message Khushboo Vashi 2017-12-11 12:33:58 Re: [pgAdmin4][Patch]: Fixed RM #2779 - Lost field size