Re: [pgAdmin4][Patch]: Fixed RM #2779 - Lost field size

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Fixed RM #2779 - Lost field size
Date: 2017-12-13 15:44:22
Message-ID: CA+OCxowTWjAy1v7dNWnHYYvL8YWT7KEQQ33yVTNiN7Hee9kiFA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Mon, Dec 11, 2017 at 12:46 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

>
> On Mon, Dec 11, 2017 at 6:03 PM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Mon, Dec 11, 2017 at 5:45 PM, Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> On Mon, Dec 11, 2017 at 5:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Hi
>>>>
>>>> On Wed, Dec 6, 2017 at 5:45 AM, Khushboo Vashi <
>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Please find the attached patch to fix RM #2779: Lost field size.
>>>>>
>>>>> While editing the table column, if we change collate then, the length
>>>>> and the precision are lost.
>>>>> Also, while changing column type, it does not honour the length and
>>>>> precision.
>>>>>
>>>>
>>>> Now it loses the collation if you edit the length.
>>>>
>>>> Fixed.
> Please find the attached patch.
>
>> I have tested it, it's not loosing the collation.
>>> Please let me know the steps to reproduce this.
>>>
>> Reproduced. Will send the patch.
>>
>>> :-(
>>>>
>>>>
>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-12-13 15:47:21 pgAdmin 4 commit: Preferences dialogue help update.
Previous Message Dave Page 2017-12-13 15:44:14 pgAdmin 4 commit: Ensure column collation isn't lost when changing fiel