Re: [pgadmin4] Edb package support.

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin4] Edb package support.
Date: 2016-08-18 05:20:18
Message-ID: CAFOhELdX6H59Tm+D+rKe9iSL4V2GJ4AHXYyHsmDRVJwu2eQz+g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Aug 17, 2016 at 4:35 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi,
>
> I did some quick testing, and found the following issues:
>
> - Package ACL is not shown in properties
>
> - Package header and body are not shown in properties
>
> - System package? is not shown in properties
>
> - The header for the RE SQL on a package procedure should read:
>
> -- Package Procedure
>
> (not -- Package Function)
>
> Can you also have someone (Khushboo?) do a code review, if that hasn't
> happened already?
>
>
Sure, will do this.

> Thanks.
>
> On Tue, Aug 16, 2016 at 1:31 PM, Harshal Dhumal
> <harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA initial patch for edb packages.
> >
> > Other changes:
> > 1] Added 'canEdit' flag for node to enable/disabled node edit. (by
> default
> > it's enable)
> > 2] Privileges: Do not show 'ALL' in query if object has only one
> applicable
> > privilege instead show that privilege.
> >
> >
> > --
> > Harshal Dhumal
> > Software Engineer
> >
> > EnterpriseDB India: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-08-18 06:24:04 PATCH: To fix the issue in configuration error message (pgAdmin4)
Previous Message Dave Page 2016-08-17 14:23:27 Re: [pgAdmin4][Debugger]: Fix RM-1224