From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgadmin4] Edb package support. |
Date: | 2016-08-17 11:05:09 |
Message-ID: | CA+OCxoypx4eiSaV=NL32kAmQgppcOTzP90GMk6bv_SD4wuq8gw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
I did some quick testing, and found the following issues:
- Package ACL is not shown in properties
- Package header and body are not shown in properties
- System package? is not shown in properties
- The header for the RE SQL on a package procedure should read:
-- Package Procedure
(not -- Package Function)
Can you also have someone (Khushboo?) do a code review, if that hasn't
happened already?
Thanks.
On Tue, Aug 16, 2016 at 1:31 PM, Harshal Dhumal
<harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA initial patch for edb packages.
>
> Other changes:
> 1] Added 'canEdit' flag for node to enable/disabled node edit. (by default
> it's enable)
> 2] Privileges: Do not show 'ALL' in query if object has only one applicable
> privilege instead show that privilege.
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-08-17 12:20:09 | pgAdmin 4 commit: Allow customisation of the CodeMirror font size. Fixe |
Previous Message | Murtuza Zabuawala | 2016-08-17 10:19:31 | PATCH: SlickGrid integration in query tool (pgAdmin4) |