Re: [pgAdmin4][Patch]: Feature tests for PG utilities

Hi Dave,

On Thu, Jul 5, 2018 at 7:47 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Thu, Jul 5, 2018 at 12:49 PM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Thu, Jul 5, 2018 at 5:09 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>>
>>>
>>> On Thu, Jul 5, 2018 at 12:30 PM, Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>>
>>>>
>>>> On Thu, Jul 5, 2018 at 4:39 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Thu, Jul 5, 2018 at 10:42 AM, Khushboo Vashi <
>>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find the attached patch which contains the feature tests for
>>>>>> PG utilities #3206.
>>>>>>
>>>>>> Thanks,
>>>>>> Khushboo
>>>>>>
>>>>>
>>>>> I'm seeing the attached error when running the tests. Unfortunately
>>>>> there's nothing more useful in the logs.
>>>>>
>>>>> I am not facing this issue. Is backup/restore working fine on your
>>>> system?
>>>>
>>>>>
>>> Yes, it seems to be.
>>>
>>> Not able to reproduce this issue. Can you try with different PG server?
>> I have tested with PG 9.6, 10 and 11.
>>
>
> This is from the first test with 11:
>
> Please find the attached updated patch.

Thanks,
Khushboo

> 2018-07-05 14:56:26,036:ERROR:STDERR:==================================
> ====================================
> 2018-07-05 14:56:26,036:ERROR:STDERR:ERROR: runTest
> (pgadmin.feature_tests.pg_utilities_backup_restore_test.PGUt
> ilitiesBackupFeatureTest)
> 2018-07-05 14:56:26,036:ERROR:STDERR:Test for PG utilities - Backup and
> Restore
> 2018-07-05 14:56:26,037:ERROR:STDERR:----------------------------------
> ------------------------------------
> 2018-07-05 14:56:26,037:ERROR:STDERR:Traceback (most recent call last):
> 2018-07-05 14:56:26,037:ERROR:STDERR: File "/Users/dpage/git/pgadmin4/web
> /pgadmin/feature_tests/pg_utilities_backup_restore_test.py", line 110, in
> runTest
> 2018-07-05 14:56:26,037:ERROR:STDERR: self.page.fill_input_by_field_name("file",
> "test_backup")
> 2018-07-05 14:56:26,037:ERROR:STDERR: File "/Users/dpage/git/pgadmin4/web
> /regression/feature_utils/pgadmin_page.py", line 212, in
> fill_input_by_field_name
> 2018-07-05 14:56:26,037:ERROR:STDERR: self.wait_for_input_field_content(field_name,
> field_content)
> 2018-07-05 14:56:26,037:ERROR:STDERR: File "/Users/dpage/git/pgadmin4/web
> /regression/feature_utils/pgadmin_page.py", line 258, in
> wait_for_input_field_content
> 2018-07-05 14:56:26,037:ERROR:STDERR: "field to contain '" +
> str(content) + "'", input_field_has_content
> 2018-07-05 14:56:26,037:ERROR:STDERR: File "/Users/dpage/git/pgadmin4/web
> /regression/feature_utils/pgadmin_page.py", line 344, in _wait_for
> 2018-07-05 14:56:26,037:ERROR:STDERR: "Timed out waiting for " +
> waiting_for_message
> 2018-07-05 14:56:26,037:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pga
> dmin4/lib/python3.6/site-packages/selenium/webdriver/support/wait.py",
> line 80, in until
> 2018-07-05 14:56:26,037:ERROR:STDERR: raise TimeoutException(message,
> screen, stacktrace)
> 2018-07-05 14:56:26,037:ERROR:STDERR:selenium.common.exceptions.TimeoutException:
> Message: Timed out waiting for field to contain 'test_backup'
>
>
>
> Once it hangs there, it never recovers and all the following tests fail (I
> guess we need to ensure that all tests reset the state at the beginning?).
>
> On the next attempt, it got stuck on the restore (see the second
> screenshot) - however, it did recover from that failure and go on to
> complete future tests:
>
> 2018-07-05 15:09:15,493:ERROR:STDERR:==================================
> ====================================
> 2018-07-05 15:09:15,493:ERROR:STDERR:ERROR: runTest
> (pgadmin.feature_tests.pg_utilities_backup_restore_test.PGUt
> ilitiesBackupFeatureTest)
> 2018-07-05 15:09:15,493:ERROR:STDERR:Test for PG utilities - Backup and
> Restore
> 2018-07-05 15:09:15,493:ERROR:STDERR:----------------------------------
> ------------------------------------
> 2018-07-05 15:09:15,494:ERROR:STDERR:Traceback (most recent call last):
> 2018-07-05 15:09:15,494:ERROR:STDERR: File "/Users/dpage/git/pgadmin4/web
> /pgadmin/feature_tests/pg_utilities_backup_restore_test.py", line 110, in
> runTest
> 2018-07-05 15:09:15,494:ERROR:STDERR: self.page.fill_input_by_field_name("file",
> "test_backup")
> 2018-07-05 15:09:15,494:ERROR:STDERR: File "/Users/dpage/git/pgadmin4/web
> /regression/feature_utils/pgadmin_page.py", line 212, in
> fill_input_by_field_name
> 2018-07-05 15:09:15,494:ERROR:STDERR: self.wait_for_input_field_content(field_name,
> field_content)
> 2018-07-05 15:09:15,494:ERROR:STDERR: File "/Users/dpage/git/pgadmin4/web
> /regression/feature_utils/pgadmin_page.py", line 258, in
> wait_for_input_field_content
> 2018-07-05 15:09:15,494:ERROR:STDERR: "field to contain '" +
> str(content) + "'", input_field_has_content
> 2018-07-05 15:09:15,494:ERROR:STDERR: File "/Users/dpage/git/pgadmin4/web
> /regression/feature_utils/pgadmin_page.py", line 344, in _wait_for
> 2018-07-05 15:09:15,494:ERROR:STDERR: "Timed out waiting for " +
> waiting_for_message
> 2018-07-05 15:09:15,494:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pga
> dmin4/lib/python3.6/site-packages/selenium/webdriver/support/wait.py",
> line 80, in until
> 2018-07-05 15:09:15,494:ERROR:STDERR: raise TimeoutException(message,
> screen, stacktrace)
> 2018-07-05 15:09:15,495:ERROR:STDERR:selenium.common.exceptions.TimeoutException:
> Message: Timed out waiting for field to contain 'test_backup'
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>