Re: [pgAdmin4][Patch]: Feature tests for PG utilities

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Feature tests for PG utilities
Date: 2018-07-09 10:28:09
Message-ID: CA+OCxoy5P3xnksDMx=Lq3Yak4mf+m3=Z6tA45_G9+x1=42r5ng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Jul 9, 2018 at 10:30 AM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
>
> On Thu, Jul 5, 2018 at 7:47 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Thu, Jul 5, 2018 at 12:49 PM, Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> On Thu, Jul 5, 2018 at 5:09 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>>
>>>>
>>>> On Thu, Jul 5, 2018 at 12:30 PM, Khushboo Vashi <
>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Thu, Jul 5, 2018 at 4:39 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Thu, Jul 5, 2018 at 10:42 AM, Khushboo Vashi <
>>>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Please find the attached patch which contains the feature tests for
>>>>>>> PG utilities #3206.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Khushboo
>>>>>>>
>>>>>>
>>>>>> I'm seeing the attached error when running the tests. Unfortunately
>>>>>> there's nothing more useful in the logs.
>>>>>>
>>>>>> I am not facing this issue. Is backup/restore working fine on your
>>>>> system?
>>>>>
>>>>>>
>>>> Yes, it seems to be.
>>>>
>>>> Not able to reproduce this issue. Can you try with different PG server?
>>> I have tested with PG 9.6, 10 and 11.
>>>
>>
>> This is from the first test with 11:
>>
>> Please find the attached updated patch.
>

Looks good here :-). Patch applied - thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2018-07-09 10:49:15 [pgAdmin4][patch] AJAX call related changes for jQuery 3
Previous Message Dave Page 2018-07-09 10:27:33 pgAdmin 4 commit: Add feature tests for Backup/Restore and Maintenance.